framework/view: experiment to extract out svelte into a swappable "viewer" #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmueller
commented
Jul 22, 2022
framework/view/loader.go
Outdated
| @@ -87,6 +86,7 @@ func (l *loader) Load(ctx context.Context) (state *State, err error) { | |||
| l.imports.AddNamed("budclient", "github.com/livebud/bud/package/budclient") | |||
| } | |||
| l.imports.AddNamed("viewrt", "github.com/livebud/bud/framework/view/viewrt") | |||
| l.imports.AddNamed("svelte", l.module.Import("viewer/svelte")) | |||
There was a problem hiding this comment.
WIP: hardcoded
framework/view/viewrt/viewer.go
Outdated
| Handler(route string, props interface{}) http.Handler | ||
| Render(w http.ResponseWriter, viewPath string, props interface{}) | ||
| Serve(router *router.Router) | ||
| } |
There was a problem hiding this comment.
This interface still needs some work, but I just wanted to get something working.
internal/virtual/file.go
Outdated
| @@ -0,0 +1,67 @@ | |||
| package virtual | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
This is a copy from both conjure and fscache. I'd like to consolidate those implementations into virtual.
package/budclient/client.go
Outdated
| "github.com/livebud/bud/package/socket" | ||
| ) | ||
|
|
||
| type Client interface { | ||
| js.VM | ||
| fs.FS | ||
| Render(route string, props interface{}) (*ssr.Response, error) | ||
| Proxy(w http.ResponseWriter, r *http.Request) |
There was a problem hiding this comment.
This PR would make Render and Proxy obsolete.
package/di/function.go
Outdated
| if !sameImport && isInterface(param.kind) && !isInterface(input.Kind) && !strings.HasPrefix(input.Type, "*") { | ||
| // TODO: input.Kind.String() != "unknown" is flaky. The unknown kind should | ||
| // be removed altogether. | ||
| if !sameImport && isInterface(param.kind) && !isInterface(input.Kind) && input.Kind.String() != "unknown" && !strings.HasPrefix(input.Type, "*") { |
There was a problem hiding this comment.
Fixed a bug in DI where aliasing an interface with an external interface would cause compilation errors. The fix added to a hack that should be cleaned up eventually.
matthewmueller
force-pushed
the
viewer
branch
from
28d36a0
to
baba60b
Compare
matthewmueller
force-pushed
the
viewer
branch
from
baba60b
to
460fb50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experiment to support swapping out the view renderers. Currently we have just one Svelte "viewer", but it'd be nice to be able to define your own viewers. This would allow for other viewers like GoHTML, HTML and React.
I haven't decided if this interface should be exposed as a generator yet, but at the very least the internal interfaces will be capable of supporting other types of renderers. If it does make sense to expose it, what should we call this? Viewers? Renderers? Templates? Something else?