Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arch][arm] Enable distributor with ARE, group 1 #427

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

gilbert0225
Copy link

Refering Zircon's 'gic_init' function, enable ARE and Group 1 added.
For arm_generic_timer configuration, 'arm64_get_boot_el' and 'arm64_is_kernel_in_hyp_mode' added to make decision for the hypervisor/virtual timer irq.

arch/arm64/arch.c Outdated Show resolved Hide resolved
Copy link
Member

@travisg travisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few little nits but otherwise great, thanks!

arch/arm64/include/arch/arm64.h Outdated Show resolved Hide resolved
@travisg
Copy link
Member

travisg commented Jan 4, 2025

Note this still doesn't work on qemu arm64 with gic version set to 3, but this was definitely an oversight.

Easy to test with ./scripts/do-qemuarm -6 and observe that IRQs arent firing.

@travisg
Copy link
Member

travisg commented Jan 4, 2025

Thanks!

@travisg travisg merged commit 97e526c into littlekernel:wip/gicv3 Jan 4, 2025
183 of 189 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants