Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to v3 themeing #15

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: update to v3 themeing #15

wants to merge 15 commits into from

Conversation

JacobCoffee
Copy link
Member

@JacobCoffee JacobCoffee commented Apr 5, 2024 •
edited

Description

Previews

Details

Core

image

API Docs

image

Landing
image

Usage
image

@JacobCoffee JacobCoffee mentioned this pull request Apr 6, 2024
Closed
5 tasks
@JacobCoffee

This comment was marked as resolved.

Sign in to view
@JacobCoffee
Copy link
Member Author

Version tab code blocks from auto_pytabs is not rendering properly (e.g., no rounded corners, bg color different than .. code-block:: directives

image

@JacobCoffee
Copy link
Member Author

JacobCoffee commented Apr 6, 2024 •
edited

In general also code-block and .. literalinclude:: highlighting is weird compared to v2 docs

edit: seems they are using

--syntax-dark-text: 
--syntax-light-text:

and that is painful :\

@JacobCoffee
Copy link
Member Author

JacobCoffee commented Apr 6, 2024 •
edited

Not sure if I'm dumb but enabling [Source] button for code isnt rendering like it has in https://docs.byte-bot.app/latest/byte/api/bot.html or https://docs.advanced-alchemy.jolt.rs/latest/reference/base.html

@JacobCoffee JacobCoffee mentioned this pull request Apr 6, 2024
Merged
@JacobCoffee
Copy link
Member Author

Hi @lepture sorry for the rogue ping, but related to your color PR from the other the Advanced Alchemy repo I thought you might have some good insight into possible improvements here.

No pressure - we just appreciate your lib a whole lot :)

lepture
lepture reviewed Apr 10, 2024
View reviewed changes
litestar_sphinx_theme/__init__.py
# waiting for shibuya#32
# context["reddit_link"] = theme_options.get(
# "reddit_link",
context["reddit_url"] = theme_options.get(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shibuya theme supports Reddit natively now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! thats why I uncommented and added.
This is so that we dont need to define it in each of our projects conf.py 😄. Actually set in theme.conf this seems sortve redundant but i was keeping with the prior work in letting people set it differently if for some reason

@JacobCoffee
Copy link
Member Author

Version words do not show but caret dropdown does. Probably a me issue to fix before v3 release
image

@JacobCoffee
Copy link
Member Author

I'm not sure what the cause/purpose of this hamburger menu is.
image

@lepture
Copy link

lepture commented Apr 10, 2024

@JacobCoffee the hamburger menu should only be shown in mobile viewport.

provinzkraut
provinzkraut approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@provinzkraut provinzkraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @JacobCoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lepture lepture lepture left review comments

@provinzkraut provinzkraut provinzkraut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JacobCoffee @lepture @provinzkraut