temp commit for Hai's check: add support for multiple roles #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-hai
reviewed
Aug 13, 2021
| } | ||
| } | ||
|
|
||
| define( 'LITESPEED_WP_ROLE', $role ); | ||
| define( 'LITESPEED_WP_ROLE', $roles ); |
There was a problem hiding this comment.
Did you test this on PHP5.3?
hi-hai
reviewed
Aug 13, 2021
| } | ||
| } | ||
| Debug2::debug( '[Router] get_role: ' . $role ); | ||
| Debug2::debug( '[Router] get_roles: ' . var_export( $roles, true ) ); |
There was a problem hiding this comment.
debug function supports 2nd param which can be an array.
hi-hai
reviewed
Aug 13, 2021
| * @param array $roles The roles of the current user | ||
| * @return boolean | ||
| */ | ||
| public function has_optm_exc_role( $roles = null ) { |
There was a problem hiding this comment.
Why don't reuse or rename in_optm_exc_roles function?
hi-hai
reviewed
Aug 13, 2021
| */ | ||
| public function in_optm_exc_roles( $role = null ) { | ||
| // Get user role | ||
| if ( $role === null ) { | ||
| $role = Router::get_role(); |
There was a problem hiding this comment.
If dropped $role assignment in in_optm_exc_roles, will this break the existing code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look and give me some feedback on how to proceed.