hot fix unwrap withink cli id-graph-hash #2697
Conversation
|
I'm fine with it but if we want to do this, we probably need to do it for all CLI commands. |
| @@ -36,8 +36,14 @@ impl IDGraphHashCommand { | |||
| let mrenclave = direct_api.get_state_mrenclave().unwrap(); | |||
| let shard = ShardIdentifier::decode(&mut &mrenclave[..]).unwrap(); | |||
| let identity = Identity::from_did(self.did.as_str()).unwrap(); | |||
| let id_graph_hash = direct_api.get_id_graph_hash(&shard, &identity).unwrap(); | |||
| println!("{:?}", id_graph_hash); | |||
| match direct_api.get_id_graph_hash(&shard, &identity) { | |||
There was a problem hiding this comment.
Why not expect ?
It can panic with more friendly message, additionaly Ok is not returned (there was a failure).
There was a problem hiding this comment.
What Ok is not returned?
There was a problem hiding this comment.
unwrap previously prevented from returning Ok from function.
After you fix, even if there is an error the function will return Ok
|
The reason I want to add it is: I need to do a group of |
|
close for the moment. |
as title. a small fix.