Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liqoctl: get cluster config #2253

Closed
wants to merge 1 commit into from
Closed

Liqoctl: get cluster config #2253

wants to merge 1 commit into from

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Dec 29, 2023 •
edited by fra98
Loading

Description

This pr adds the possibility to retrieve information about the local cluster (e.g., cluster-id) with liqoctl.

You can retrieve:

  • a json or yaml containing all gathered information
  • a string containing the clusterID with the --cluster-id flag

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/liqoctl-cluster-config branch 2 times, most recently from 6121ffa to 1df3cc9 Compare January 3, 2024 09:51
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Jan 3, 2024
@aleoli aleoli added the hold Prevent bot merging label Jan 3, 2024
@aleoli aleoli marked this pull request as ready for review January 3, 2024 10:44
@aleoli aleoli requested review from cheina97 and fra98 January 3, 2024 10:44
@cheina97 cheina97 added the kind/feature New feature or request label Jan 9, 2024
@fra98 fra98 force-pushed the aol/liqoctl-cluster-config branch from a9ce1bf to 2677464 Compare August 30, 2024 10:04
@fra98 fra98 changed the base branch from network-external to master August 30, 2024 10:04
@fra98 fra98 force-pushed the aol/liqoctl-cluster-config branch from 2677464 to bb16f53 Compare August 30, 2024 10:20
@fra98
Copy link
Member

fra98 commented Sep 5, 2024

Closing this PR as it is replaced by #2718.

@fra98 fra98 closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
hold Prevent bot merging kind/feature New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleoli @adamjensenbot @fra98 @cheina97