Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPAMStorage namespaced #2023

Closed
wants to merge 1 commit into from
Closed

IPAMStorage namespaced #2023

wants to merge 1 commit into from

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Sep 15, 2023 •
edited
Loading

Description

This PR moves the IPAMStorage inside the liqo namespace.
This allows IPAM to be deleted when Liqois uninstalled

How Has This Been Tested?

  • Locally with KinD

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 15, 2023
@cheina97
Copy link
Member Author

/build

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 added the kind/breaking Breaking change label Sep 15, 2023
@cheina97
Copy link
Member Author

/hold

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Sep 15, 2023
@cheina97
Copy link
Member Author

/rebase test=true

@fra98 fra98 closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
hold Prevent bot merging kind/breaking Breaking change size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheina97 @adamjensenbot @aleoli @fra98