Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liqoctl Force Unpeer Command #1112

Closed
wants to merge 2 commits into from
Closed

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Feb 15, 2022

Description

This pr adds a command to (force) purge a liqo peering between 2 clusters

In particular, it adds 2 ways:

  • liqoctl purge --kubeconfig-1 liqo_kubeconf_1 --kubeconfig-2 liqo_kubeconf_2 providing both the kubeconfigs. It cleans the peering from both clusters
  • liqoctl purge --kubeconfig-1 liqo_kubeconf_1 --remote-cluster other-cluster providing the kubeconfig of one of the two and the name of the other. It cleans the peering from a cluster (useful when the other cluster is no more reachable)

How Has This Been Tested?

  • locally, with 2 running clusters
  • locally, with 1 running cluster
    • peer 2 kind clusters
    • delete 1 of the 2
    • purge the other one

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /doc-build Trigger the build of the Liqo documentation

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/force-unpeer branch 2 times, most recently from 5ade7cd to 9cf0180 Compare February 15, 2022 14:08
@aleoli aleoli force-pushed the aol/force-unpeer branch 5 times, most recently from 2a63e8f to 20d4864 Compare March 11, 2022 11:07
@aleoli aleoli force-pushed the aol/force-unpeer branch 4 times, most recently from ec4218e to c665d76 Compare March 14, 2022 16:09
@aleoli
Copy link
Member Author

aleoli commented Mar 14, 2022

/test

@aleoli aleoli marked this pull request as ready for review March 14, 2022 16:39
@aleoli aleoli requested review from alacuku and giorio94 March 14, 2022 16:39
pkg/liqoctl/purge/handler.go Outdated Show resolved Hide resolved
pkg/liqoctl/purge/types.go Outdated Show resolved Hide resolved
pkg/liqoctl/purge/handler.go Outdated Show resolved Hide resolved
cmd/liqoctl/cmd/purge.go Outdated Show resolved Hide resolved
pkg/liqoctl/purge/handler.go Outdated Show resolved Hide resolved
pkg/liqoctl/purge/handler.go Outdated Show resolved Hide resolved
cmd/liqoctl/cmd/purge.go Outdated Show resolved Hide resolved
@aleoli aleoli marked this pull request as draft April 4, 2022 09:06
@aleoli aleoli force-pushed the aol/force-unpeer branch 5 times, most recently from 06d06c4 to 1845d60 Compare April 4, 2022 14:33
@aleoli
Copy link
Member Author

aleoli commented Apr 4, 2022

/test

@aleoli aleoli marked this pull request as ready for review April 4, 2022 15:09
@aleoli aleoli requested a review from giorio94 April 4, 2022 15:09
@aleoli
Copy link
Member Author

aleoli commented Apr 5, 2022

/test

aleoli added a commit to aleoli/liqo that referenced this pull request Apr 6, 2022
aleoli added a commit to aleoli/liqo that referenced this pull request Apr 6, 2022
@aleoli aleoli added the hold Prevent bot merging label Apr 6, 2022
@aleoli
Copy link
Member Author

aleoli commented Apr 6, 2022

/test

@aleoli aleoli removed the hold Prevent bot merging label Apr 6, 2022
@giorio94 giorio94 added the kind/feature New feature or request label Apr 15, 2022
pkg/liqoctl/purge/handler.go Outdated Show resolved Hide resolved
pkg/liqoctl/purge/handler.go Outdated Show resolved Hide resolved
pkg/liqoctl/purge/handler.go Outdated Show resolved Hide resolved
@aleoli aleoli force-pushed the aol/force-unpeer branch 2 times, most recently from 47d3474 to 60abbd8 Compare April 19, 2022 09:57
@giorio94
Copy link
Member

/hold Waiting for the linter to be fixed.

@giorio94 giorio94 marked this pull request as draft April 21, 2022 07:50
@aleoli
Copy link
Member Author

aleoli commented May 10, 2022

/rebase test=true

@aleoli
Copy link
Member Author

aleoli commented Jul 21, 2022

/rebase test=true

@giorio94 giorio94 self-requested a review August 2, 2022 12:40
@fra98 fra98 closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants