Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set errexit pragma #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MitchellPaff
Copy link
Contributor

@MitchellPaff MitchellPaff commented Jan 30, 2022

Failure (when running locally with set -x):

Warning: Could not find base configuration, try setting the BDECOPY_DATADIR env variable to a directory containing a file with the same base name as the executable and the .cfg extension

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 31, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@MitchellPaff MitchellPaff force-pushed the refactor/set-errexit-pragma branch from a8cba2e to b741df4 Compare January 31, 2022 00:17
l0b0
l0b0 previously approved these changes Feb 7, 2022
@l0b0 l0b0 force-pushed the refactor/set-errexit-pragma branch from 4dfb939 to 647d1ec Compare March 8, 2022 23:41
@l0b0
Copy link
Contributor

l0b0 commented Oct 2, 2022

Failure investigation:

  1. The error happens on the "$exe" -c ../test5.cfg ../par1.crs par5a.out par5a.log line.
  2. bde_copy returns 1 when running that line, with an error message "Cannot open metadata file ../par1.crs.hdr".
  3. The previous line, "$exe" -c ../test4.cfg ../par1.crs par4.out par4.log, succeeded. The only difference between the two lines is the output files and the .cfg files. The only difference between the .cfg files is that test5.cfg has a metadata_extension .hdr line, which looks like it's relevant.
  4. The metadata_extension .hdr line has always been in that .cfg file.

I'll need to do a quick bisect applying this change at every step to figure out when this started failing, but for now I assume it's been failing forever, since there's no direct validation of the result of every single command.

@l0b0 l0b0 force-pushed the refactor/set-errexit-pragma branch from aecd658 to d642aa8 Compare November 20, 2022 20:43
@l0b0 l0b0 added the automerge label Dec 20, 2022
Mitchell Paff and others added 2 commits February 9, 2023 12:46
@l0b0 l0b0 force-pushed the refactor/set-errexit-pragma branch from 41cbae1 to 797689b Compare February 8, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants