Add readonly_supported to readme-vars.yml #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
From my own testing it seems like running this container in read_only mode works without any issues so I've updated the readme template to signal this to users. It's possible that my use case for Syncthing does not cover edge cases that causes problems with read_only mode. Please let me know and disregard this pull request if so.
Benefits of this PR and context:
It reflects your efforts to mark containers compatible with read_only mode as such.
How Has This Been Tested?
I added
read_only: trueto the containers docker compose file and did some basic testing to make sure that no functionality had been lost and that no errors or warnings showed up in the logs. Syncing files worked as expected.Source / References:
#91