[pythongen] Simplify slot generation iterators #2001
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that most of the logic of the slot and postinit generation iteration logic in pythongen was just sorting, and also made some potentially expensive calls multiple time. unified a sorting method and trimmed down unused/duplicated code. generated kitchen sink and biolink and both were identical.
sorting usually a lil easier to maintain than truth tables <3.
marginal perf benefit, the lions share of time is still in
induced_slot
since ig the changes i made there got deployed but we haven't updated the lockfile here yet?