Skip to content

refactor: move modules from utils to types #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Silvanoc
Copy link
Contributor

@Silvanoc Silvanoc commented May 20, 2025

Move modules defining types rather than utilities from linkml_runtime.utils to linkml_runtime.types.

Part of refactoring proposed in issue linkml/linkml#2371

Move modules defining types rather than utilities from
`linkml_runtime.utils` to `linkml_runtime.types`.

Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 60.86957% with 18 lines in your changes missing coverage. Please review.

Project coverage is 63.76%. Comparing base (9501812) to head (b60f1f9).

Files with missing lines Patch % Lines
linkml_runtime/linkml_model/datasets.py 0.00% 5 Missing ⚠️
linkml_runtime/linkml_model/validation.py 0.00% 5 Missing ⚠️
linkml_runtime/linkml_model/mappings.py 0.00% 3 Missing ⚠️
linkml_runtime/utils/permissiblevalueimpl.py 0.00% 3 Missing ⚠️
linkml_runtime/utils/schemaview.py 0.00% 1 Missing ⚠️
linkml_runtime/utils/yamlutils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files          63       63           
  Lines        8942     8942           
  Branches     2586     2586           
=======================================
  Hits         5702     5702           
  Misses       2631     2631           
  Partials      609      609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Silvanoc
Copy link
Contributor Author

Silvanoc commented May 20, 2025

Keeping it as Draft until issues on main are fixed and tests can succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant