Fix Kustomize for multicluster demo #1762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Marick <[email protected]>
bmarick
force-pushed
the
multiclusterKustomizeFix
branch
from
c4689e8
to
50fa4e9
Compare
|
Superseded by #1815 -- many thanks for getting the ball rolling here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #1722
Updates the multicluster demo to work with newer versions of kustomize.
This was tested by installing kubectl-v1.26.12 and generating the resulting manifeststs.
Next, I updated the files to work with kubectl-v1.28.3.
Finally, I diffed the resulting manifests to ensure that there was no differences.
NOTE there was a couple of difference due to order of containers and environment variables being generated.
But nothing that should impact the result.