chore(proxy/http): address hyper::client::conn::SendRequest deprecation
#3410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
force-pushed
the
kate/hyper-1.x-send-request
branch
from
1e51908 to
d9e5a3c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
…tion this commit updates code in `linkerd-proxy-http`'s HTTP/2 client code, and the `linkerd-app-test` crate's `TestServer`, to use the new `hyper::client::conn::http2::SendRequest` backported from the 1.x major release. see <hyperium/hyper#2960> for more information. this commit refrains from updating the broader client connection system, and addresses the breaking changes to `SendRequest` made in the 1.0 major release, namely: * send request is no longer a tower service: * <https://docs.rs/hyper/0.14.31/hyper/client/conn/struct.SendRequest.html#impl-Service%3CRequest%3CB%3E%3E-for-SendRequest%3CB%3E> * <https://docs.rs/hyper/1.5.1/hyper/client/conn/http2/struct.SendRequest.html#trait-implementations> * `send_request()` now returns an anonymous `impl Future` and not a named `ResponseFuture`, as in `0.14`. * <https://docs.rs/hyper/0.14.31/hyper/client/conn/struct.ResponseFuture.html> * <https://docs.rs/hyper/1.5.1/hyper/client/conn/http2/struct.SendRequest.html#method.send_request> NB: this change depends on <hyperium/hyper#3798>. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/hyper-1.x-send-request
branch
from
d9e5a3c to
5a3fbd9
Compare
cratelyn
changed the title
hyper::client::conn::SendRequest depreca…hyper::client::conn::SendRequest deprecation
Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/hyper-1.x-send-request
branch
from
5a3fbd9 to
9ebf533
Compare
ci failing on account of the patched dependency 👍 |
|
i am going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit updates code in
linkerd-proxy-http's HTTP/2 client code, and thelinkerd-app-testcrate'sTestServer, to use the newhyper::client::conn::http2::SendRequestbackported from the 1.x major release.see hyperium/hyper#2960 for more information.
this commit refrains from updating the broader client connection system, and addresses the breaking changes to
SendRequestmade in the 1.0 major release, namely:send request is no longer a tower service:
send_request()now returns an anonymousimpl Futureand not a namedResponseFuture, as in0.14.NB: this change depends on hyperium/hyper#3798.