Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps OPA to version 1.0 release to fix integration tests and docker setup #275

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

Will-Lo
Copy link
Collaborator

@Will-Lo Will-Lo commented Dec 24, 2024

Summary

Issue Briefly discuss the summary of the changes made in this pull request in 2-3 lines.

OPA recently released version 1.0.0 which is not backwards compatible. Since our docker images were using the latest versions of OPA, there were some changes needed in order to be compatible with the released major version.
https://github.com/open-policy-agent/opa/releases/tag/v1.0.0

Opted to fix-forward rather than revert to 0.70.0 as it seems 1.0.0 is a significant release which should be supported for longer term.

Changes

  • Client-facing API Changes
  • Internal API Changes
  • Bug Fixes
  • New Features
  • Performance Improvements
  • Code Style
  • Refactoring
  • Documentation
  • Tests

Ensures that the GHA CI/CD will wait for build-and-test to pass before releasing. Although PRs are validated, there was still a miss when there are docker/GHA version releases in between the last PR CI validation run and the merge time

Validated the rules work using the OPA 1.0 binary and followed the compatibility guide
https://www.openpolicyagent.org/docs/latest/v0-compatibility/

Needed to explicitly bind the port of the server to 0.0.0.0 as it now defaults to localhost, causing an issue when being accessed by other containers.

Testing Done

  • Manually Tested on local docker setup. Please include commands ran, and their output.
  • Added new tests for the changes made.
  • Updated existing tests to reflect the changes made.
  • No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
  • Some other form of testing like staging or soak time in production. Please explain.

Tested that this works e2e by running the integration tests and running the local docker setup.

Additional Information

  • Breaking Changes
  • Deprecations
  • Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

Additional Information

  • Breaking Changes
  • Deprecations
  • Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

@Will-Lo Will-Lo changed the title Opa 1.0 support integration tests Bumps OPA to version 1.0 release to fix integration tests and docker setup Dec 24, 2024
Copy link
Collaborator

@sumedhsakdeo sumedhsakdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @Will-Lo

@Will-Lo Will-Lo merged commit f12fb15 into linkedin:main Jan 2, 2025
1 check passed
@Will-Lo Will-Lo deleted the opa-1.0-support-integration-tests branch January 3, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants