Fix race condition in glob collections #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When subscribing to a glob collection that is being updated, the `nonNilValueNames` set was being accessed in an unprotected way. This was generally safe as it was only used by new subscribers when they subscribed to empty collections. However, it was still potentially problematic. This fix not only addresses this race condition, but by refactoring `NotifyHandlerAfterSubscription`, it also allows multiple subscribers to subscribe to the glob collection concurrently. This will hopefully speed up the processing of new clients subscribing to many large glob collections all at once (which can happen during startup).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subscribing to a glob collection that is being updated, the
nonNilValueNamesset was being accessed in an unprotected way. This was generally safe as it was only used by new subscribers when they subscribed to empty collections. However, it was still potentially problematic. This fix not only addresses this race condition, but by refactoringNotifyHandlerAfterSubscription, it also allows multiple subscribers to subscribe to the glob collection concurrently. This will hopefully speed up the processing of new clients subscribing to many large glob collections all at once (which can happen during startup).