Add more metrics for compaction and sealed replicas and enable compaction after bootstrap #3006
+152
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a replica starts bootstrapping on a host, we disable compaction for this replica. This makes sense since bootstrap process employs the regular replication protocol, which would ignore expired and deleted blob. There are not many blobs to compact. However, after bootstrap finishes, this replica would start serving client requests, more blobs will be deleted and expired. We should enable compaction after bootstrap.
This PR fixed this issue by adding logic to enable compaction in storage manager.
This PR also exposes two more metrics
Testing Done
Wait for unit test