[FileCopy based bootstrap] Added changes for filestore implementation #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyujai
force-pushed
the
filestore_implementation
branch
5 times, most recently
from
f4ef4c7 to
eaa73d2
Compare
piyujai
force-pushed
the
filestore_implementation
branch
from
eaa73d2 to
a8a0427
Compare
added 2 commits
February 13, 2025 05:14
piyujai
force-pushed
the
filestore_implementation
branch
from
d7b6dd1 to
b44a273
Compare
piyujai
force-pushed
the
filestore_implementation
branch
2 times, most recently
from
0e4fc01 to
0b93349
Compare
piyujai
changed the title
piyujai
force-pushed
the
filestore_implementation
branch
from
0b93349 to
25cdc87
Compare
piyujai
force-pushed
the
filestore_implementation
branch
from
25cdc87 to
8f4d5d8
Compare
ambry-store/src/main/java/com/github/ambry/store/FileStore.java
Outdated
Show resolved
Hide resolved
DevenAhluwalia
requested changes
Feb 14, 2025
ambry-api/src/main/java/com/github/ambry/clustermap/FileStoreException.java
Outdated
Show resolved
Hide resolved
ambry-api/src/main/java/com/github/ambry/config/FileCopyConfig.java
Outdated
Show resolved
Hide resolved
ambry-api/src/main/java/com/github/ambry/config/FileCopyConfig.java
Outdated
Show resolved
Hide resolved
ambry-store/src/main/java/com/github/ambry/store/FileStore.java
Outdated
Show resolved
Hide resolved
ambry-store/src/main/java/com/github/ambry/store/FileStore.java
Outdated
Show resolved
Hide resolved
ambry-store/src/main/java/com/github/ambry/store/FileStore.java
Outdated
Show resolved
Hide resolved
ambry-store/src/main/java/com/github/ambry/store/FileStore.java
Outdated
Show resolved
Hide resolved
ambry-store/src/main/java/com/github/ambry/store/FileStore.java
Outdated
Show resolved
Hide resolved
ambry-store/src/main/java/com/github/ambry/store/FileStore.java
Outdated
Show resolved
Hide resolved
piyujai
force-pushed
the
filestore_implementation
branch
from
ba36bc1 to
fb860f6
Compare
| */ | ||
| public static final String FILECOPY_FILE_CHUNK_TIMEOUT_IN_MINUTES = "filecopy.file.chunk.timeout.in.minutes"; | ||
| @Config(FILECOPY_FILE_CHUNK_TIMEOUT_IN_MINUTES) | ||
| public final long filecopyFileChunkTimeoutInMins; |
There was a problem hiding this comment.
Can you provide a default value?
| * - Associated index segments | ||
| * - Bloom filters for efficient lookups | ||
| */ | ||
| public class LogInfo { |
There was a problem hiding this comment.
Can you drive consensus with @DevenAhluwalia to finalize where this POJO will stay? It is part of both store/LogInfo and protocol/LogInfo
There was a problem hiding this comment.
This is WIP. I am testing a change where interface resides in api module and Store and Protocol classes implement that interface thus protocol/pojos will not be required anymore.
This'll come as part of PR#2991
There was a problem hiding this comment.
Update; This is fixed as part of latest diff pushed in PR#2991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented FileStore for FileCopy based replication
Key Changes
Key Changes
Testing Details: