Merge pull request #62 from lineupjs/release/v2.5.0

Release v2.5.0

.github/workflows/release_main.yml

@@ -98,12 +98,12 @@ jobs:
           yarn config set npmAuthToken "${{ secrets.NPM_TOKEN }}"
           yarn pack
           yarn npm publish --tag "${{ needs.create_release.outputs.npm_tag }}"
-      - name: Upload Release Asset
-        uses: AButler/[email protected]
-        with:
-          files: '*.tgz'
-          repo-token: ${{ secrets.PRIVATE_GITHUB_TOKEN }}
-          release-tag: ${{ needs.create_release.outputs.tag_name }}
+      # - name: Upload Release Asset
+      #   uses: AButler/[email protected]
+      #   with:
+      #     files: '*.tgz'
+      #     repo-token: ${{ secrets.PRIVATE_GITHUB_TOKEN }}
+      #     release-tag: ${{ needs.create_release.outputs.tag_name }}
 
   sync_dev:
     needs: correct_repository

.stylelintrc

@@ -1,16 +1,19 @@
 {
-  "plugins": [
-    "stylelint-scss",
-    "stylelint-prettier",
+  "extends": [
+    "stylelint-config-prettier-scss",
+    "stylelint-config-standard-scss"
   ],
-  "extends": "stylelint-config-standard",
   "rules": {
-    "prettier/prettier": true,
+    "string-quotes": "single",
+    "no-descending-specificity": null,
+    "value-list-comma-newline-after": null,
     "declaration-colon-newline-after": null,
     "at-rule-no-unknown": null,
     "at-rule-empty-line-before": null,
     "block-closing-brace-newline-after": null,
+    "selector-id-pattern": null,
     "scss/at-rule-no-unknown": true,
+    "scss/no-global-function-names": null,
     "scss/at-extend-no-missing-placeholder": true,
     "scss/at-else-closing-brace-newline-after": "always-last-in-chain",
     "scss/at-else-closing-brace-space-after": "always-intermediate",

.yarnrc.yml

@@ -6,4 +6,4 @@ packageExtensions:
     dependencies:
       eslint-import-resolver-node: "*"
 
-yarnPath: .yarn/releases/yarn-3.1.0.cjs
+yarnPath: .yarn/releases/yarn-3.2.2.cjs

README.md

@@ -39,6 +39,8 @@ see [Main API documentation](https://lineupengine.js.org/main/docs) and [Develop
 
 ## Development Environment
 
+The setup requires [Node.js v16 or higher](https://nodejs.org/en/download/).
+
 ```sh
 git clone https://github.com/lineupjs/lineupengine.git
 cd lineupengine

package.json

@@ -2,7 +2,7 @@
   "name": "lineupengine",
   "description": "a fast engine for rendering large tables consisting of rows, rows+columns, multiple rows+columns instances.",
   "homepage": "https://lineupengine.js.org",
-  "version": "2.4.2",
+  "version": "2.5.0",
   "author": {
     "name": "Samuel Gratzl",
     "email": "[email protected]",
@@ -37,69 +37,73 @@
     "!build/demo"
   ],
   "scripts": {
-    "clean": "rimraf build dist docs \"*.tgz\" && yarn run clean:compile",
+    "clean": "rimraf build dist docs \"*.tgz\" && npm run clean:compile",
     "clean:compile": "rimraf build/src \"build/*.tsbuildinfo\" \"*.tsbuildinfo\" ",
     "compile": "tsc -b ./tsconfig.json",
     "compile:dev": "tsc -b ./tsconfig.dev.json",
-    "fix": "yarn run eslint:fix && yarn run prettier:write",
+    "fix": "npm run eslint:fix && npm run prettier:write && npm run stylelint:fix",
     "prettier:write": "prettier \"*\" \"*/**\" --write",
     "prettier": "prettier \"*\" \"*/**\" --check",
     "eslint": "eslint src demo --ext .ts,.tsx",
-    "eslint:fix": "yarn run eslint --fix",
+    "eslint:fix": "npm run eslint --fix",
     "stylelint": "stylelint \"src/**/*.scss\"",
-    "lint": "yarn run eslint && yarn run prettier && yarn run stylelint",
-    "docs": "yarn run clean:compile && typedoc --tsconfig tsconfig.dev.json --out ./docs/ src tsd.d.ts",
-    "test": "jest --passWithNoTests",
-    "test:watch": "jest --passWithNoTests --watch",
-    "test:coverage": "jest --passWithNoTests --coverage",
+    "stylelint:fix": "npm run stylelint --fix",
+    "lint": "npm run eslint && npm run prettier && npm run stylelint",
+    "docs": "npm run clean:compile && typedoc --tsconfig tsconfig.dev.json --out ./docs/ src tsd.d.ts",
+    "test": "jest --passWithNoTests --detectOpenHandles --forceExit",
+    "test:watch": "npm run test --watch",
+    "test:coverage": "npm run test --coverage",
     "build:dev": "webpack --mode development --devtool source-map",
     "build": "webpack --mode production --devtool source-map",
-    "dev": "yarn run clean && yarn run compile:dev && yarn run build:dev",
+    "dev": "npm run clean && npm run compile:dev && npm run build:dev",
     "watch": "webpack --mode development --watch --devtool source-map",
     "start": "webpack serve --mode development --devtool source-map",
     "prepare": "echo 'dummy prepare since prepack has no dev dependencies'",
-    "prepack": "yarn run clean && yarn run compile && yarn run build"
+    "prepack": "npm run clean && npm run compile && npm run build"
   },
   "devDependencies": {
-    "@types/jest": "^27.0.3",
-    "@typescript-eslint/eslint-plugin": "^5.4.0",
-    "@typescript-eslint/parser": "^5.4.0",
-    "@yarnpkg/sdks": "^2.5.1-rc.3",
-    "css-loader": "^6.5.1",
-    "eslint": "^8.3.0",
-    "eslint-config-airbnb-typescript": "^16.0.0",
-    "eslint-config-prettier": "^8.3.0",
-    "eslint-config-react-app": "^6.0.0",
+    "@types/jest": "^28.1.6",
+    "@typescript-eslint/eslint-plugin": "^5.30.7",
+    "@typescript-eslint/parser": "^5.30.7",
+    "@yarnpkg/sdks": "^2.6.2",
+    "css-loader": "^6.7.1",
+    "eslint": "^8.20.0",
+    "eslint-config-airbnb-typescript": "^17.0.0",
+    "eslint-config-prettier": "^8.5.0",
+    "eslint-config-react-app": "^7.0.1",
     "eslint-plugin-flowtype": "^8.0.3",
-    "eslint-plugin-import": "^2.25.3",
-    "eslint-plugin-jsx-a11y": "^6.5.1",
-    "eslint-plugin-prettier": "^4.0.0",
-    "eslint-plugin-react": "^7.27.1",
-    "eslint-plugin-react-hooks": "^4.3.0",
-    "fork-ts-checker-webpack-plugin": "^6.4.2",
-    "jest": "^27.3.1",
-    "mini-css-extract-plugin": "^2.4.5",
+    "eslint-plugin-import": "^2.26.0",
+    "eslint-plugin-jsx-a11y": "^6.6.1",
+    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-react": "^7.30.1",
+    "eslint-plugin-react-hooks": "^4.6.0",
+    "fork-ts-checker-webpack-plugin": "^7.2.13",
+    "jest": "^28.1.3",
+    "jest-environment-jsdom": "^28.1.3",
+    "mini-css-extract-plugin": "^2.6.1",
     "mkdirp": "^1.0.4",
-    "prettier": "^2.4.1",
+    "postcss": "^8.4.14",
+    "prettier": "^2.7.1",
     "rimraf": "^3.0.2",
-    "sass": "^1.43.4",
-    "sass-loader": "^12.3.0",
+    "sass": "^1.53.0",
+    "sass-loader": "^13.0.2",
     "style-loader": "^3.3.1",
-    "stylelint": "^13",
-    "stylelint-config-standard": "^22",
-    "stylelint-prettier": "^1",
-    "stylelint-scss": "^3",
+    "stylelint": "^14.9.1",
+    "stylelint-config-prettier-scss": "^0.0.1",
+    "stylelint-config-standard-scss": "^5.0.0",
+    "stylelint-prettier": "^2.0.0",
+    "stylelint-scss": "^4.3.0",
     "thread-loader": "^3.0.4",
-    "ts-jest": "^27.0.7",
-    "ts-loader": "^9.2.6",
-    "typedoc": "^0.22.9",
-    "typescript": "~4.4",
-    "webpack": "^5.64.3",
-    "webpack-cli": "^4.9.1",
-    "webpack-dev-server": "^4.5.0"
+    "ts-jest": "^28.0.7",
+    "ts-loader": "^9.3.1",
+    "typedoc": "^0.23.8",
+    "typescript": "^4.7.4",
+    "webpack": "^5.73.0",
+    "webpack-cli": "^4.10.0",
+    "webpack-dev-server": "^4.9.3"
   },
   "dependencies": {
-    "tslib": "^2.3.1"
+    "tslib": "^2.4.0"
   },
-  "packageManager": "yarn@3.1.0"
+  "packageManager": "yarn@3.2.2"
 }

src/styles/_import_once.scss

@@ -7,10 +7,10 @@ $imported-modules: () !default;
 // @param {Bool} $warn [true] - Warn when module has been already imported
 // @require $imported-modules
 @mixin exports($name, $warn: true) {
-  @if (index($imported-modules, $name) == null) {
+  @if not index($imported-modules, $name) {
     $imported-modules: append($imported-modules, $name) !global;
     @content;
   } @else if $warn == true {
-    @warn "Module `#{$name}` has already been imported.";
+    @warn 'Module `#{$name}` has already been imported.';
   }
 }

src/styles/_layout.scss

@@ -55,15 +55,23 @@
     box-sizing: border-box;
     transform: translateZ(0);
 
-    &:hover,
-    &.#{$engine_css_prefix}-highlighted {
-      @include collapsing-row-border($engine_row_outline_width, $engine_row_outline_color);
-    }
-
     &.#{$engine_css_prefix}-even {
       background-clip: content-box;
       background-color: $engine_even_color;
     }
+
+    @if $engine_highlight_mode == 'background' {
+      &:hover,
+      &.#{$engine_css_prefix}-highlighted {
+        background-color: $engine_row_background_color;
+        @include collapsing-row-border($engine_row_outline_width, $engine_row_outline_color);
+      }
+    } @else {
+      &:hover,
+      &.#{$engine_css_prefix}-highlighted {
+        @include collapsing-row-border($engine_row_outline_width, $engine_row_outline_color);
+      }
+    }
   }
 
   .#{$engine_css_prefix}-tbody {
@@ -89,6 +97,17 @@
     background-color: $engine_even_color;
   }
 
+  @if $engine_highlight_mode != 'outline' {
+    .#{$engine_css_prefix}-tr {
+      &:hover,
+      &.#{$engine_css_prefix}-highlighted {
+        > .#{$engine_css_prefix}-td.#{$engine_css_prefix}-shifted.#{$engine_css_prefix}-frozen {
+          background-color: $engine_row_background_color;
+        }
+      }
+    }
+  }
+
   .#{$engine_css_prefix}-td {
     position: absolute;
     left: 0;

src/styles/_vars.scss

@@ -3,8 +3,13 @@ $engine_even_color: #f7f7f7 !default;
 $engine_assets: './assets' !default;
 $engine_loading_image: url('#{$engine_assets}/loading.svg') !default;
 $engine_loading_static_image: url('#{$engine_assets}/loading_s.svg') !default;
+// 'outline' or 'background';
+// $engine_highlight_mode: 'background' !default;
+$engine_highlight_mode: 'outline' !default;
+
 $engine_row_outline_color: #ffa500 !default;
 $engine_row_outline_width: 2px !default;
+$engine_row_background_color: #ffa500 !default;
 
 // see also animation/index.ts MAX_ANIMATION_TIME
 $engine_animation_update_duration: 0.5s;