Update pydantic to v2 #496

Activity

1. tokuhirom

   added

   enhancement

   on Jul 25, 2023
2. tokuhirom commented on Jul 25, 2023

   

   tokuhirom

   on Jul 25, 2023

   ContributorAuthor

   More actions

   We need to rewrite PythonNextgenCustomClientGenerator with the latest style.

   diff --git generator/src/main/java/line/bot/generator/PythonNextgenCustomClientGenerator.java generator/src/main/java/line/bot/generator/PythonNextgenCustomClientGenerator.java
   index 7d84030..e0e57f1 100644
   --- generator/src/main/java/line/bot/generator/PythonNextgenCustomClientGenerator.java
   +++ generator/src/main/java/line/bot/generator/PythonNextgenCustomClientGenerator.java
   @@ -443,10 +443,10 @@ public class PythonNextgenCustomClientGenerator extends AbstractPythonCodegen im
            if (cp.isArray) {
                String constraints = "";
                if (cp.maxItems != null) {
   -                constraints += String.format(Locale.ROOT, ", max_items=%d", cp.maxItems);
   +                constraints += String.format(Locale.ROOT, ", max_length=%d", cp.maxItems);
                }
                if (cp.minItems != null) {
   -                constraints += String.format(Locale.ROOT, ", min_items=%d", cp.minItems);
   +                constraints += String.format(Locale.ROOT, ", min_length=%d", cp.minItems);
                }
                if (cp.getUniqueItems()) {
                    constraints += ", unique_items=True";
   @@ -723,10 +723,10 @@ public class PythonNextgenCustomClientGenerator extends AbstractPythonCodegen im
            if (cp.isArray) {
                String constraints = "";
                if (cp.maxItems != null) {
   -                constraints += String.format(Locale.ROOT, ", max_items=%d", cp.maxItems);
   +                constraints += String.format(Locale.ROOT, ", max_length=%d", cp.maxItems);
                }
                if (cp.minItems != null) {
   -                constraints += String.format(Locale.ROOT, ", min_items=%d", cp.minItems);
   +                constraints += String.format(Locale.ROOT, ", min_length=%d", cp.minItems);
                }
                if (cp.getUniqueItems()) {
                    constraints += ", unique_items=True";
3. tokuhirom commented on Jul 25, 2023

   

   tokuhirom

   on Jul 25, 2023

   ContributorAuthor

   More actions

   BTW, there's a remaining error.

   ================================== short test summary info ===================================
   FAILED tests/v3/test_webhook.py::TestWebhookParser::test_parse - TypeError: unhashable type: 'ModelPrivateAttr'
   FAILED tests/v3/test_webhook.py::TestWebhookParser::test_parse_webhook_req_without_destination - TypeError: unhashable type: 'ModelPrivateAttr'
   FAILED tests/v3/test_webhook.py::TestWebhookHandler::test_handler - TypeError: unhashable type: 'ModelPrivateAttr'
   

   Why it's happened?
4. tokuhirom commented on Jul 25, 2023

   

   tokuhirom

   on Jul 25, 2023

   ContributorAuthor

   More actions

   https://docs.pydantic.dev/latest/migration/
   There's a migration guide.
5. tokuhirom

   added 2 commits that reference this issue on Jul 25, 2023

   update pydantic from v1 to v2.

   ...

   ae86013

   update pydantic from v1 to v2. (#497)

   ...

   7296de7