Fix flaky ServerStatusManagerIntegrationTest (2) #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This PR tries to solve the flakiness of `ServerStatusManagerIntegrationTest` in a different way. See line#948 This workaround minimizes port collisions by ensuring that all ports are available when a Central Dogma cluster starts. Modifications: - Check if all ports are open when restarting `CentralDogmaReplicationExtension`. Result: Less flakiness
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
============================================
+ Coverage 66.86% 70.54% +3.68%
- Complexity 3529 3684 +155
============================================
Files 370 376 +6
Lines 14531 14796 +265
Branches 1563 1591 +28
============================================
+ Hits 9716 10438 +722
+ Misses 3936 3428 -508
- Partials 879 930 +51 ☔ View full report in Codecov by Sentry. |
|
Oops, could you check the failure? |
jrhee17
approved these changes
Jun 13, 2024
|
I tried to increase the max attempts although it won't be a perfect solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This PR tries to solve the flakiness of
ServerStatusManagerIntegrationTestin a different way. See #948This workaround minimizes port collisions by ensuring that all ports are available when a Central Dogma cluster starts.
Modifications:
CentralDogmaReplicationExtension.Result:
Less flakiness