feat: enhance user management table with user context and selection logic #1486
Conversation
WalkthroughThe changes introduce new restrictions and UI feedback in the user management features of the application. On the backend, the member service now excludes users with the type 'SUPER' when fetching project members. On the frontend, the user management table and its columns are updated to prevent the currently logged-in user from selecting or deleting their own user entry. Additionally, a "Me" badge is displayed next to the logged-in user's email in the table, and some minor logic improvements and logging were added to the table's selection handling. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UserManagementTable
participant useUserStore
User->>UserManagementTable: Render table
UserManagementTable->>useUserStore: Get current user's email
UserManagementTable-->>User: Display table
alt Row is current user
UserManagementTable-->>User: Disable selection and delete for own row
UserManagementTable-->>User: Show "Me" badge next to email
else Other users
UserManagementTable-->>User: Enable selection and delete
end
sequenceDiagram
participant MemberService
participant Database
MemberService->>Database: Query members by project ID
Note right of MemberService: Excludes users where type = 'SUPER'
Database-->>MemberService: Return filtered members
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/src/entities/user/user-columns.tsx (1)
35-43: Remove debugging console.log statements.The console.log statements appear to be debugging code that should be removed before merging to production.
indeterminate={ table.getIsSomeRowsSelected() && !table.getIsAllRowsSelected() } onCheckedChange={(checked) => { - console.log('checked: ', checked); - console.log(table.getIsAllRowsSelected()); table.toggleAllRowsSelected(checked); }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/api/src/domains/admin/project/member/member.service.ts(1 hunks)apps/web/src/entities/user/ui/user-management-table.ui.tsx(4 hunks)apps/web/src/entities/user/user-columns.tsx(4 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/web/src/entities/user/user-columns.tsx (1)
apps/web/src/entities/user/user.model.ts (1)
useUserStore(44-98)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: integration-test
🔇 Additional comments (7)
apps/api/src/domains/admin/project/member/member.service.ts (1)
108-108: Filter implementation for excluding SUPER type users looks good.The addition of this filter ensures that users with the 'SUPER' type are not included in the project member results, aligning with the security principle of restricting visibility of privileged accounts in regular user management interfaces.
apps/web/src/entities/user/ui/user-management-table.ui.tsx (3)
43-43: Good addition of useUserStore for user context.The import and use of the user store provides necessary context for implementing the user-based restrictions in the table.
Also applies to: 54-54
93-93: Security improvement for preventing self-selection.This is a good safety measure that prevents users from selecting their own record, which could lead to accidental self-deletion.
187-187: Security enhancement for preventing self-deletion.Disabling the delete button when editing the current user's record adds an additional layer of protection against accidental account deletion.
apps/web/src/entities/user/user-columns.tsx (3)
24-24: Good addition of useUserStore for identifying the current user.This import enables the "Me" badge feature to highlight the current user's record in the table.
59-68: Good implementation of the "Me" badge for self-identification.Adding a visual indicator next to the current user's email helps with identification in the table. It also visually reinforces which user record cannot be selected or deleted based on the restrictions added in the table component.
99-101: Good code simplification for type column.The refactoring of these methods to use arrow function shorthand improves code readability without changing functionality.
Summary by CodeRabbit
New Features
Bug Fixes
UI Improvements