TF-3267 Implement HTML attachment preview #3327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tddang-linagora
temporarily deployed
to
PR-3327
GitHub Actions
Inactive
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3327. |
|
hi @chibenwa , please take a look on the UI for HTML preview. Hope to get your feedback to improve it. Thanks |
tddang-linagora
temporarily deployed
to
PR-3327
GitHub Actions
Inactive
tddang-linagora
temporarily deployed
to
PR-3327
GitHub Actions
Inactive
dab246
reviewed
Dec 9, 2024
lib/features/email/domain/usecases/get_html_content_from_attachment_interactor.dart
Outdated
Show resolved
Hide resolved
dab246
reviewed
Dec 9, 2024
lib/features/email/presentation/controller/single_email_controller.dart
Outdated
Show resolved
Hide resolved
lib/features/email/presentation/controller/single_email_controller.dart
Outdated
Show resolved
Hide resolved
tddang-linagora
temporarily deployed
to
PR-3327
GitHub Actions
Inactive
tddang-linagora
temporarily deployed
to
PR-3327
GitHub Actions
Inactive
dab246
reviewed
Dec 9, 2024
lib/features/email/domain/usecases/get_html_content_from_attachment_interactor.dart
Outdated
Show resolved
Hide resolved
Screen.Recording.2024-12-09.at.16.07.29.mov |
|
tddang-linagora
temporarily deployed
to
PR-3327
GitHub Actions
Inactive
tddang-linagora
temporarily deployed
to
PR-3327
GitHub Actions
Inactive
tddang-linagora
temporarily deployed
to
PR-3327
GitHub Actions
Inactive
can-close-when-click-outside.mov
can-open-external-link.mov
can-view-content.mov
can-download.mov |
|
dab246
reviewed
Dec 11, 2024
core/lib/presentation/utils/html_transformer/text/standardize_html_sanitizing_transformers.dart
Show resolved
Hide resolved
dab246
reviewed
Dec 11, 2024
lib/features/email/presentation/widgets/html_attachment_previewer.dart
Outdated
Show resolved
Hide resolved
dab246
reviewed
Dec 11, 2024
lib/features/email/presentation/widgets/html_attachment_previewer.dart
Outdated
Show resolved
Hide resolved
dab246
reviewed
Dec 11, 2024
lib/features/email/presentation/widgets/html_attachment_previewer.dart
Outdated
Show resolved
Hide resolved
dab246
reviewed
Dec 11, 2024
Weblate - web-based localization.html.zip Screen.Recording.2024-12-11.at.13.42.16.mov |
Screen.Recording.2024-12-11.at.14.07.07.mov |
Fix size and add loading Preview-loading.mov |
Screen.Recording.2024-12-11.at.16.52.06.mov |
dab246
reviewed
Dec 12, 2024
core/test/utils/standardize_html_sanitizing_transformers_test.dart
Outdated
Show resolved
Hide resolved
tddang-linagora
force-pushed
the
feature/TF-3267-html-attachment-preview
branch
from
a077366 to
1cf3756
Compare
tddang-linagora
temporarily deployed
to
PR-3327
GitHub Actions
Inactive
dab246
reviewed
Dec 16, 2024
Comment on lines
+46
to
+47
| child: ColoredBox( | ||
| color: Colors.transparent, |
There was a problem hiding this comment.
It is needed for GestureDetector to receive tap outside Html view
dab246
reviewed
Dec 16, 2024
| children: [ | ||
| TopBarAttachmentViewer( | ||
| title: title, | ||
| closeAction: Get.back, |
There was a problem hiding this comment.
Suggested change
| closeAction: Get.back, | |
| closeAction: popBack, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Demo
Screen.Recording.2024-12-09.at.13.17.46.mov