Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-2948 Apply new identity view #3322

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

TF-2948 Apply new identity view #3322

wants to merge 4 commits into from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Dec 4, 2024

Issue

#2948

Resolved

  • Web:
Screen.Recording.2024-12-04.at.16.36.18.mov
  • Mobile:
demo-android.webm

@dab246 dab246 requested a review from hoangdat December 4, 2024 09:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3322.

@hoangdat
Copy link
Member

  • it is nested scroll in this screen (both mobile/web), it makes user sometime hared to scroll, especially in mobile. So I propose to disable scroll for preview signature, fixed height for this. WDYT?
    image

@hoangdat
Copy link
Member

  • Create new profile button is moving up when identity list loading. Should keep it pins to bottom of screen
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@hoangdat hoangdat Awaiting requested review from hoangdat

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dab246 @hoangdat @tddang-linagora