-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] TF-2955 Reduce time in opening tmail app #2959
base: refactor
Are you sure you want to change the base?
[POC] TF-2955 Reduce time in opening tmail app #2959
Conversation
This PR has been deployed to https://linagora.github.io/tmail-flutter/2959. |
} | ||
|
||
void getSessionAction() { | ||
void getSessionAction({PersonalAccount? personalAccount}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused PersonalAccount
param, consider remove
bool isResynchronized = false; | ||
bool isShowingWarningDialogSessionExpired = false; | ||
bool isShowingWarningDialogResynchronizeSessionFailure = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these bool be replaced by enum
?
if (apiUrl.isNotEmpty) { | ||
updateAuthenticationAccount( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid checking apiUrl.isNotEmpty in multiple location, should we move this if
check inside updateAuthenticationAccount
?
Issue
#2955
Solution
Demo
Synchronize session success
demo-success.mov
Synchronize session failure
demo-failure.mov
Resynchronize session failure
Screen.Recording.2024-06-25.at.11.53.04.online-video-cutter.com.mp4