Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic attachments #1466

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Magic attachments #1466

wants to merge 5 commits into from
+149 −6

Conversation

chibenwa
Copy link
Member

@chibenwa chibenwa commented Jan 15, 2025 •
edited
Loading

Very WIP

I need to:

  • Triage those changes locally
  • Needs "benchmarks" - gatling?
  • And indeed to reduce the boiler plate eg by not copying TMailCleverMailboxSessionMapperFactory which makes for halth of the code base added here

See the related James PR

@chibenwa chibenwa mentioned this pull request Jan 15, 2025
Draft
@chibenwa
Copy link
Member Author

Also it would need code reorganisation so that reusable pieces can benefit the PG app, for instance...

@chibenwa chibenwa mentioned this pull request Jan 15, 2025
Open
@chibenwa
Allow customizing only the attachment id assignation
d4626cc 
Ease writing custom logic for this a LOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chibenwa