C++17 lambda + parallel #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure how much slower/faster the lambda paradiam is, so let's be safe and run the comparison before we decide.
|
You forgot to update benchmark.toml. Also can you update countlines? |
A colon in the name is now understood to not change the $name attribute. The TOML has been updated for C++17.
lilydjwg
requested changes
Jan 15, 2020
bench.py
Outdated
| @@ -117,7 +117,8 @@ def load_config(): | |||
| profile['name'] = name | |||
There was a problem hiding this comment.
Shouldn't this line be deleted?
There was a problem hiding this comment.
No. Just because we are defining ${name} as meaning "name without the front part" does not mean we can leave it undefined in the dict.
There was a problem hiding this comment.
But won't there be multiple name arguments passed into safe_substitute?
C++17/Makefile
Outdated
|
|
||
| swapview-par-lam: swapview.cpp | ||
| $(CXX) swapview.cpp -o swapview-par-lam $(PAR) $(LAM) $(CXXFLAGS) | ||
| strip swapview |
There was a problem hiding this comment.
The above is stripping a wrong binary.
|
This doesn't compile (C++17) with latest gcc / g++ from Arch. Is there anything missed or changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure how much slower/faster the lambda paradiam is, so let's be safe and run the comparison before we decide whether the old impl should be kept.