Skip to content

Conversation

@alexislefebvre
Copy link
Collaborator

@alexislefebvre alexislefebvre commented Dec 10, 2025

'https://symfony.com/doc/5.4/testing.html#logging-in-users-authentication'
),
\E_USER_DEPRECATED
trigger_deprecation(
Copy link
Collaborator Author

@alexislefebvre alexislefebvre Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is called by other methods:

Deprecated the following methods, use [loginUser() from Symfony 5.1+](https://symfony.com/doc/5.4/testing.html#logging-in-users-authentication) instead of:
- `makeClient`
- `makeAuthenticatedClient`
- `makeClientWithCredentials`
- `loginAs`
- `loginClient`
- `createClientWithParams`

I’m not sure that __METHOD__ returned this method or the method that called it.

TODO: check it. And if necessary, add deprecations to the caller methods.

@alexislefebvre alexislefebvre marked this pull request as draft December 10, 2025 13:55
@alexislefebvre alexislefebvre self-assigned this Dec 10, 2025
@alexislefebvre alexislefebvre changed the title feat: use symfony/deprecation contracts to report deprecations feat: use symfony/deprecation-contracts to report deprecations Dec 11, 2025
@alexislefebvre
Copy link
Collaborator Author

Current code and symfony/deprecation-contracts use silented deprecations, that are not reported by PHPUnit.

Maybe we should just remove @ from current deprecations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rely on symfony/deprecation-contracts for deprecations

1 participant