document.getElementsByTagName #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
domdoc-gelementsby
branch
2 times, most recently
from
0ec6dc5 to
291db12
Compare
krichprollsch
force-pushed
the
domdoc-gelementsby
branch
from
8c46d0e to
c0e41f0
Compare
krichprollsch
changed the title
krichprollsch
force-pushed
the
domdoc-gelementsby
branch
from
c0e41f0 to
d61b7a0
Compare
We can't simply use the libdom dom_document_get_elements_by_tag_name because it follows an old version of the specifications and returns a NodeList. Since whatwg/dom@190700b the spec changed in favor of returning an HTMLCollection. So I'm trying to re-implement the HTMLCollection in zig.
The buffer is used for upper case string transformation.
We don't want expose the function to the JS API.
krichprollsch
force-pushed
the
domdoc-gelementsby
branch
from
d61b7a0 to
6f2e59d
Compare
krichprollsch
force-pushed
the
domdoc-gelementsby
branch
from
a174179 to
3ca6a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement array like accessors (relates to Array like syntax support zig-js-runtime#126)post ponedWe can't simply use the libdom
dom_document_get_elements_by_tag_namebecause it follows an old version of the specifications and returns aNodeList.Since whatwg/dom@190700b the spec changed in favor of returning an HTMLCollection.
So I'm trying to re-implement the HTMLCollection in zig.
Relates to #18