Window: add EventTargetBase #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
window-event-target
branch
from
b75c602 to
0526792
Compare
krichprollsch
changed the title
krichprollsch
force-pushed
the
window-event-target
branch
from
0526792 to
160a8e4
Compare
krichprollsch
force-pushed
the
window-event-target
branch
from
160a8e4 to
8522928
Compare
EventTargetBase implements event target vtable for pure zig struct
krichprollsch
force-pushed
the
window-event-target
branch
from
8522928 to
5aef5a2
Compare
src/html/window.zig
Outdated
| @@ -1,6 +1,9 @@ | |||
| const std = @import("std"); | |||
|
|
|||
| const parser = @import("../netsurf.zig"); | |||
| const c = @cImport({ | |||
There was a problem hiding this comment.
Why do we need this? I do not see any call to c.<something> .
And if we need it, it should be imported in netsurf.zig, I think we should try to keep the APIs away from the C code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventTargetBase implements event target vtable for pure zig struct
Relates to #170
blocked by #36