Merged
Conversation
Collaborator
|
Hi @jsoref, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Akka Contributors License Agreement before, however, the CLA has changed since you last signed it. |
jsoref
commented
Apr 14, 2026
Comment on lines
+23
to
+31
| # Retrieve the Scala SBT public key | ||
| curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2EE0EA64E40A89B84B2DF73499E82A75642AC823" | | ||
| sudo tee /usr/share/keyrings/scala-sbt.asc > /dev/null | ||
|
|
||
| # Add the sbt repositories to apt sources | ||
| echo "deb https://repo.scala-sbt.org/scalasbt/debian all main" | sudo tee /etc/apt/sources.list.d/sbt.list | ||
| echo "deb https://repo.scala-sbt.org/scalasbt/debian /" | sudo tee /etc/apt/sources.list.d/sbt_old.list | ||
|
|
||
| # Import the Scala SBT public key | ||
| curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2EE0EA64E40A89B84B2DF73499E82A75642AC823" \ | ||
| | sudo apt-key add - | ||
| echo "deb [signed-by=/usr/share/keyrings/scala-sbt.asc] https://repo.scala-sbt.org/scalasbt/debian all main" | | ||
| sudo tee /etc/apt/sources.list.d/sbt.list | ||
| echo "deb [signed-by=/usr/share/keyrings/scala-sbt.asc] https://repo.scala-sbt.org/scalasbt/debian /" | | ||
| sudo tee /etc/apt/sources.list.d/sbt_old.list |
Contributor
Author
There was a problem hiding this comment.
| /** | ||
| * Like {@link #parseApplicationReplacement()} but allows you to specify a class loader | ||
| * ti yse rather than the current context class loader. | ||
| * rather than using the current context class loader. |
| Akka Contributor License Agreement online, using your GitHub | ||
| account - it takes 30 seconds. You can do this at | ||
| https://www.lightbend.com/contribute/cla | ||
| https://contribute.akka.io/contribute/cla |
Contributor
Author
There was a problem hiding this comment.
Tangentially related, at the top right of this page are two links:
If you click either link and then click LOGIN WITH GITHUB, you will encounter:
Contributor
Author
|
@lightbend-cla-validator for the record, I have signed it again, but you should really fix the link w/ which you respond to use the current URL instead of the old url 😉. |
Collaborator
|
Please put the build related changes in a separate PR from the spelling ones. |
Merged
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read Maintained by
I'm happy to split or drop things if people are interested.
Akka replaced Lightbend, so the CLA link redirects which means you should apply 5808a5d or something very close to it.
The rest are more typical spelling / grammar fixes -- I started on this repository because we use it transitively and I generally send PR contributions to things I/we use. I'm not attached to the corrections, but I find it easier to work w/ code when it doesn't have typos.