update versions in readme examples #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to check — you've verified that the newer version actually works in this context...? |
|
Yes we are using it with no issues e.g. https://github.com/guardian/members-data-api/blob/a5bb9b3576536f362c144690712ac8922a943e47/project/Dependencies.scala#L30 although having said that intellij is letting me know that 1.5.6 is out by now! |
|
I've added another change to make the compile use that version too, as it makes no sense for me to leave it inconsistent. |
|
@johnduffell so this now incorporates #432 ? I can't approve this one or 432, the other maintainers need to make a choice here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that the readme is pointing at a version of logback with a high severity vulnerability, so I've just bumped the version to a safer one.