-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] trying to run ember-eui #25
Draft
lifeart
wants to merge
4
commits into
master
Choose a base branch
from
ember-eui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for g-next failed.
|
lifeart
force-pushed
the
ember-eui
branch
2 times, most recently
from
January 15, 2024 11:17
8a0b139
to
3890d0b
Compare
lifeart
force-pushed
the
ember-eui
branch
8 times, most recently
from
January 21, 2024 12:05
c3f6d16
to
95acffc
Compare
lifeart
force-pushed
the
ember-eui
branch
8 times, most recently
from
January 29, 2024 12:09
6983a78
to
186048b
Compare
lifeart
force-pushed
the
ember-eui
branch
2 times, most recently
from
January 30, 2024 18:00
2f2a589
to
ff28b6b
Compare
<div class={{maybeClass (if @arrowProps.className @arrowProps.className)}}></div>
|
lifeart
force-pushed
the
ember-eui
branch
2 times, most recently
from
January 30, 2024 18:33
8dbf508
to
9a7aa26
Compare
lifeart
force-pushed
the
ember-eui
branch
7 times, most recently
from
January 31, 2024 19:38
e51ceef
to
9255e1f
Compare
Code Coverage ReportCoverage after merging ember-eui into master
Coverage Report
|
lifeart
force-pushed
the
ember-eui
branch
2 times, most recently
from
February 2, 2024 09:39
2a0fd93
to
fdfc8ac
Compare
lifeart
force-pushed
the
ember-eui
branch
2 times, most recently
from
February 2, 2024 10:33
0e4cb71
to
946b2c1
Compare
todo: figure out why tab buttons not clickable |
|
lifeart
force-pushed
the
ember-eui
branch
5 times, most recently
from
February 6, 2024 15:17
9e85389
to
16a2e83
Compare
explore - sub expressions in on modifier word boundary replacement fix compiler, add helper/modifier/component helpers better modifiers EuiAccordion, EuiPanel pretty plugin + + carrying args exploration + + + + playing with ember component reactivity inside let argument + +
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm exploring drop-in ember addons compatibility
Main deps
kinda
mocked, we have to create Component -> GlimmerComponent bridge and figure out how to use our plugin to compile templates, vite did not run it over node_modules. Likely need to create custom resolver.. ?Updates: able to render icon:
1
2
3
4