Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [experiment] check signals v1 #114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

🚨 [experiment] check signals v1 #114

wants to merge 5 commits into from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Apr 30, 2024

Checking drop-in reactivity pipeline replacement with signals polyfill

image

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit c298237
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/66e98f973ddebc00080c5c52
😎 Deploy Preview https://deploy-preview-114--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 30, 2024

duration phase estimated regression +9347ms [9293ms to 9402ms] OR +308.57% [306.79% to 310.39%]
renderEnd phase no difference [0ms to 0ms]
render1000Items1End phase estimated regression +20ms [18ms to 23ms] OR +9.92% [9.03% to 11.11%]
clearItems1End phase estimated regression +176ms [175ms to 178ms] OR +984.59% [976.22% to 995.27%]
render1000Items2End phase estimated regression +125ms [34ms to 129ms] OR +285.51% [76.73% to 293.79%]
clearItems2End phase estimated regression +154ms [153ms to 164ms] OR +1130.84% [1125.65% to 1203.97%]
render5000Items1End phase estimated regression +29ms [24ms to 35ms] OR +3.58% [2.96% to 4.2%]
clearManyItems1End phase estimated regression +3734ms [3724ms to 3767ms] OR +4195.89% [4184.67% to 4233.45%]
render5000Items2End phase estimated regression +33ms [17ms to 33ms] OR +4.58% [2.33% to 4.63%]
clearManyItems2End phase estimated regression +3650ms [3634ms to 3667ms] OR +4366.7% [4348.14% to 4386.61%]
render1000Items3End phase estimated regression +119ms [118ms to 120ms] OR +378.23% [376.37% to 381.19%]
append1000Items1End phase estimated improvement -70ms [-85ms to -68ms] OR -25.91% [-31.66% to -25.3%]
append1000Items2End phase estimated regression +17ms [15ms to 17ms] OR +9.48% [8.66% to 9.55%]
updateEvery10thItem1End phase estimated regression +17ms [17ms to 17ms] OR +16.72% [16.59% to 16.8%]
updateEvery10thItem2End phase no difference [0ms to 0ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase estimated improvement -16ms [-17ms to -16ms] OR -49.21% [-51.41% to -47.75%]
removeFirstRow1End phase no difference [-1ms to 0ms]
removeSecondRow1End phase no difference [0ms to 15ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase estimated regression +1366ms [1354ms to 1379ms] OR +2999.59% [2973.24% to 3028.72%]
paint phase no difference [0ms to 1ms]

[14:33:19] Generating Benchmark Reports [started]
[14:33:27] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

// "data" cell, it's value can be updated, and it's used to create derived cells
export class Cell<T extends unknown = unknown> {
_value!: T;
_value!: Signal.State<T>;
declare toHTML: () => string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAAAS

@lifeart lifeart changed the title check-signals [experiment] check signals v1 May 3, 2024
@lifeart lifeart changed the title [experiment] check signals v1 🚨 [experiment] check signals v1 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants