Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error handling and fixed key length calculation #445

Merged
merged 5 commits into from
Jun 2, 2024
Merged

Improved error handling and fixed key length calculation #445

merged 5 commits into from
Jun 2, 2024

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented May 20, 2024 •
edited

I've

  • changed the error test, to match the comment: The check is only needed for rsa signatures (and the information is missing in keyinfo for ed25519 signatures...)
  • fixed the calculation of rsa key length
  • errors thrown in ed25519 verification have the correct type now
  • fixed some typos

@dodmi dodmi changed the title Improved error test for better comprehension Improved error handling and fixed key length calculation May 23, 2024
lieser
lieser approved these changes May 27, 2024
View reviewed changes
modules/dkimVerifier.jsm.js Show resolved Hide resolved
@lieser lieser added this to the 2.3.0 milestone May 27, 2024
@lieser lieser merged commit d80ebbd into lieser:2.x Jun 2, 2024
2 checks passed
@dodmi dodmi deleted the improve-signature-error-handling-2x-2024-05-20 branch June 3, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieser lieser lieser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dodmi @lieser