Skip to content

Exit limits utils lib : require -> revert #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

Amuhar
Copy link
Contributor

@Amuhar Amuhar commented May 30, 2025

A short summary of the changes.

Context

What the reviewer needs to know

Problem

What problem this PR solves, link relevant issue if it exists

Solution

Your proposed solution

@Amuhar Amuhar requested a review from a team as a code owner May 30, 2025 13:59
Copy link

github-actions bot commented May 30, 2025

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  --------------------------------------------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   434      11  97.47%   270-275, 556-557, 585, 1129, 1309-1316, 1399
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.25/ValidatorExitDelayVerifier.sol                   64       0  100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol                     0       0  100.00%
contracts/0.8.25/interfaces/IValidatorsExitBus.sol                 0       0  100.00%
contracts/0.8.25/lib/BeaconTypes.sol                               0       0  100.00%
contracts/0.8.25/lib/GIndex.sol                                   33      15  54.55%   22, 34, 55, 63-82, 90, 111
contracts/0.8.25/lib/SSZ.sol                                      15       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   20       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                314       2  99.36%   1491-1517
contracts/0.8.9/TriggerableWithdrawalsGateway.sol                 59       1  98.31%   304
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               32       0  100.00%
contracts/0.8.9/WithdrawalVaultEIP7002.sol                        21       0  100.00%
contracts/0.8.9/lib/ExitLimitUtils.sol                            31       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       2  98.95%   184-185
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBus.sol                     131       1  99.24%   513
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                52       1  98.08%   231
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3264      58  98.22%

Diff against master

Filename                                              Stmts    Miss  Cover
--------------------------------------------------  -------  ------  --------
contracts/0.4.24/nos/NodeOperatorsRegistry.sol          -78     +11  -2.53%
contracts/0.8.25/ValidatorExitDelayVerifier.sol         +64       0  +100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol            0       0  +100.00%
contracts/0.8.25/interfaces/IValidatorsExitBus.sol        0       0  +100.00%
contracts/0.8.25/lib/BeaconTypes.sol                      0       0  +100.00%
contracts/0.8.25/lib/GIndex.sol                         +33     +15  +54.55%
contracts/0.8.25/lib/SSZ.sol                            +15       0  +100.00%
contracts/0.8.9/LidoLocator.sol                          +2       0  +100.00%
contracts/0.8.9/StakingRouter.sol                        -2      +2  -0.64%
contracts/0.8.9/TriggerableWithdrawalsGateway.sol       +59      +1  +98.31%
contracts/0.8.9/WithdrawalVault.sol                     +11       0  +100.00%
contracts/0.8.9/WithdrawalVaultEIP7002.sol              +21       0  +100.00%
contracts/0.8.9/lib/ExitLimitUtils.sol                  +31       0  +100.00%
contracts/0.8.9/oracle/ValidatorsExitBus.sol           +131      +1  +99.24%
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol      -39      -1  +0.28%
TOTAL                                                  +248     +29  -0.82%

Results for commit: 0794a35

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

@Amuhar Amuhar merged commit db2d479 into feat/triggerable-exits May 30, 2025
9 of 10 checks passed
@Amuhar Amuhar deleted the feat/veb-refactoring branch May 30, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants