Skip to content

wip: temporary implementation for TW #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: feat/triggerable-exits
Choose a base branch
from
Draft

wip: temporary implementation for TW #1035

wants to merge 10 commits into from
+360 −499

Conversation

eddort
Copy link
Member

@eddort eddort commented Apr 15, 2025

NOR temporary implementation for TW (devnet-01)

@eddort eddort requested a review from a team as a code owner April 15, 2025 17:08
@eddort eddort marked this pull request as draft April 15, 2025 17:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 15, 2025 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  --------------------------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   489       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.25/ValidatorExitVerifier.sol                        72       3  95.83%   385, 389, 400
contracts/0.8.25/interfaces/IStakingRouter.sol                     0       0  100.00%
contracts/0.8.25/interfaces/IValidatorsExitBusOracle.sol           0       0  100.00%
contracts/0.8.25/lib/BeaconTypes.sol                               0       0  100.00%
contracts/0.8.25/lib/GIndex.sol                                   33      15  54.55%   22, 34, 55, 63-82, 90, 111
contracts/0.8.25/lib/SSZ.sol                                      15       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                314       2  99.36%   1490-1516
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               27       0  100.00%
contracts/0.8.9/WithdrawalVaultEIP7685.sol                        22       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       2  98.95%   189-190
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBus.sol                      41       3  92.68%   103, 131, 148
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol               118       2  98.31%   148, 391
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3207      52  98.38%

Diff against master

Filename                                                    Stmts    Miss  Cover
--------------------------------------------------------  -------  ------  --------
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                -23       0  +100.00%
contracts/0.8.25/ValidatorExitVerifier.sol                    +72      +3  +95.83%
contracts/0.8.25/interfaces/IStakingRouter.sol                  0       0  +100.00%
contracts/0.8.25/interfaces/IValidatorsExitBusOracle.sol        0       0  +100.00%
contracts/0.8.25/lib/BeaconTypes.sol                            0       0  +100.00%
contracts/0.8.25/lib/GIndex.sol                               +33     +15  +54.55%
contracts/0.8.25/lib/SSZ.sol                                  +15       0  +100.00%
contracts/0.8.9/StakingRouter.sol                              -2      +2  -0.64%
contracts/0.8.9/WithdrawalVault.sol                            +6       0  +100.00%
contracts/0.8.9/WithdrawalVaultEIP7685.sol                    +22       0  +100.00%
contracts/0.8.9/oracle/ValidatorsExitBus.sol                  +41      +3  +92.68%
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol            +27       0  +0.51%
TOTAL                                                        +191     +23  -0.66%

Results for commit: 966241e

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

@eddort eddort added the valset Updates from the ValSet Tech team label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
valset Updates from the ValSet Tech team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eddort