feat: add integration tests for ao extra data from scripts repo #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: f93adbc Minimum allowed coverage is ♻️ This comment has been updated with latest results |
tamtamchik
reviewed
Apr 9, 2025
There was a problem hiding this comment.
The current version looks good, and I’m inclined to approve it as is. However, I have a few suggestions:
- We could consider reusing some helper functions from the full-items test in other tests or provisioning by moving them to the protocol context.
- It would be better to use
bigintwhenever possible to avoid unnecessary typecasting. For mathematical operations, we haveBigIntMathavailable.
I haven't reviewed everything in detail since the tests are failing on CI.
test/integration/core/accounting-oracle-extra-data-full-items.integration.ts
Outdated
Show resolved
Hide resolved
test/integration/core/accounting-oracle-extra-data-full-items.integration.ts
Outdated
Show resolved
Hide resolved
|
|
||
| after(async () => await Snapshot.restore(snapshot)); | ||
|
|
||
| async function calcNodeOperatorRewards( |
There was a problem hiding this comment.
💭 Move to protocol/helpers? Just to not bloat the file and leave only test inside, to make it more readable?
| return (mintedShares * BigInt(operatorTotalActiveKeys)) / BigInt(moduleTotalActiveKeys); | ||
| } | ||
|
|
||
| async function fillModuleWithOldAndNewOperators( |
There was a problem hiding this comment.
💭 looks like we can improve current nor/sdvt protocol helpers and reuse this code for all the modules?
test/integration/core/accounting-oracle-extra-data-full-items.integration.ts
Outdated
Show resolved
Hide resolved
test/integration/core/accounting-oracle-extra-data-full-items.integration.ts
Outdated
Show resolved
Hide resolved
test/integration/core/accounting-oracle-extra-data-full-items.integration.ts
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| const { reportTx } = await report(ctx, reportData); | ||
| await reportTx?.wait(); |
There was a problem hiding this comment.
Any expectations after report? At least check events?
tamtamchik
approved these changes
Apr 9, 2025
Co-authored-by: Yuri Tkachenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration tests
from https://github.com/lidofinance/scripts/ (also adopted for #978 ).