Use Poetry for dependency management

[george-zubrienko]

Part of #413

Scope

• Removed manual publish scripts and pipfile
• Removed setup.py
• Added poetry-style toml file and dependency lockfile to ensure contributors can start up with poetry install
• Updated all pipelines to use Poetry

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
dataclasses_json
cfg.py	51	4	92%	77, 81–83
core.py	231	9	96%	38–41, 51, 64, 66, 81, 83, 169
mm.py	189	29	85%	33–36, 42–45, 53–56, 62–65, 88, 152–153, 158, 162, 166, 171, 175, 179, 187, 193, 198, 207, 212, 217, 235–242
stringcase.py	25	3	88%	59, 76, 97
undefined.py	143	2	99%	24, 38
utils.py	128	31	76%	11–24, 44–49, 60–64, 74, 77, 80, 99–100, 108–109, 158, 177, 202
tests
entities.py	220	2	99%	229, 235
test_annotations.py	81	42	48%	50–67, 78–102, 106–122
test_api.py	142	2	99%	139–140
test_str_subclass.py	22	1	95%	9
TOTAL	2406	125	95%

Tests	Skipped	Failures	Errors	Time
281	1 💤	0 ❌	0 🔥	3.787s ⏱️

[lidatong]

Awesome! Thanks for doing this. Does pyproject.toml replacing all the existing build file formats (pipenv, conda, poetry, requirements.txt) stay compatible for users?

[george-zubrienko]

Awesome! Thanks for doing this. Does pyproject.toml replacing all the existing build file formats (pipenv, conda, poetry, requirements.txt) stay compatible for users?

Should be, according to https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#declaring-project-metadata :)

Requirements can be exported into requirements.txt for pip install with https://python-poetry.org/docs/cli/#export

[george-zubrienko]

Forgot to add commit tagging workflow - will do that, update contributor section in README and then merge.
So release process will include one more step - pre-release part, to create tagged commit and a gh release accordingly.

[george-zubrienko]

@lidatong sorry for the delay, please have a look at this commit

It adds a workflow to create github release/tagged commit, so we can create releases regularly. Finally, I've modified the pythonpackage.yaml to replace version numbers from git tag so we release correct version from that flow :)

[lidatong]

@lidatong sorry for the delay, please have a look at this commit

It adds a workflow to create github release/tagged commit, so we can create releases regularly. Finally, I've modified the pythonpackage.yaml to replace version numbers from git tag so we release correct version from that flow :)

looks good thanks for making the automation better with the semver tagging! would this still work with trusted publishing? i saw the workflow is now directly running poetry publish instead of using the pypa gh action

[george-zubrienko]

@lidatong sorry for the delay, please have a look at this commit
It adds a workflow to create github release/tagged commit, so we can create releases regularly. Finally, I've modified the pythonpackage.yaml to replace version numbers from git tag so we release correct version from that flow :)

looks good thanks for making the automation better with the semver tagging! would this still work with trusted publishing? i saw the workflow is now directly running poetry publish instead of using the pypa gh action

Yeah it should work, poetry publish is basically the same as pypa gh action - but if you want we can test on one of our OSS repos first

[george-zubrienko]

Actually, we can also just do the poetry publish and publish with pypa - I think that would work 200% - will update tomorrow

[george-zubrienko]

@lidatong updated, just to make sure, this is the result of poetry build:

> ~/PycharmProjects/dataclasses-json$ poetry build
Building dataclasses-json (0.0.0)
  - Building sdist
  - Built dataclasses_json-0.0.0.tar.gz
  - Building wheel
  - Built dataclasses_json-0.0.0-py3-none-any.whl
> ~/PycharmProjects/dataclasses-json$ ls
LICENSE  README.md  dataclasses_json  dist  poetry.lock  pyproject.toml  tests  venv
> ~/PycharmProjects/dataclasses-json$ ls dist/
dataclasses_json-0.0.0-py3-none-any.whl  dataclasses_json-0.0.0.tar.gz

[lidatong]

@lidatong updated, just to make sure, this is the result of poetry build:

> ~/PycharmProjects/dataclasses-json$ poetry build
Building dataclasses-json (0.0.0)
  - Building sdist
  - Built dataclasses_json-0.0.0.tar.gz
  - Building wheel
  - Built dataclasses_json-0.0.0-py3-none-any.whl
> ~/PycharmProjects/dataclasses-json$ ls
LICENSE  README.md  dataclasses_json  dist  poetry.lock  pyproject.toml  tests  venv
> ~/PycharmProjects/dataclasses-json$ ls dist/
dataclasses_json-0.0.0-py3-none-any.whl  dataclasses_json-0.0.0.tar.gz

ok great, this looks good! we can keep trusted publishing this way. thanks again for the nice CI improvements :D