Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: surface nested mapping errors #426

Merged
merged 4 commits into from
Jun 23, 2023
Merged

fix: surface nested mapping errors #426

merged 4 commits into from
Jun 23, 2023

Conversation

skeggse
Copy link
Contributor

@skeggse skeggse commented Jun 16, 2023

Fixes #425.

@skeggse
Copy link
Contributor Author

skeggse commented Jun 16, 2023

The mypy errors look like they're already present on master, but I haven't carefully examined them.

@george-zubrienko
Copy link
Collaborator

The mypy errors look like they're already present on master, but I haven't carefully examined them.

This is not a required check yet. You can ignore this for now :)

s-vitaliy
s-vitaliy requested changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeggse, you can ignore errors in mypy for now, we will fix them. Let's fix the test and merge it :)

tests/test_nested.py Show resolved Hide resolved
@skeggse
test: use pytest.raises
b3d2bef 
I learned a new thing about pytest today
@skeggse
test: import pytest
01119d2
@skeggse skeggse requested a review from s-vitaliy June 21, 2023 20:46
@george-zubrienko george-zubrienko merged commit 8ffa594 into lidatong:master Jun 23, 2023
@skeggse skeggse deleted the fix-nested-mapping-decode branch October 2, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-vitaliy s-vitaliy s-vitaliy approved these changes

Assignees

@s-vitaliy s-vitaliy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] common errors from decoder on inner dataclass silently ignored
3 participants
@skeggse @george-zubrienko @s-vitaliy