Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy pipeline #424

Merged
merged 11 commits into from
Jun 16, 2023
Merged

Add mypy pipeline #424

merged 11 commits into from
Jun 16, 2023

Conversation

s-vitaliy
Copy link
Collaborator

@s-vitaliy s-vitaliy commented Jun 16, 2023

Part of #412
Add an optional code-quality pipeline and mypy static type checking.

Repository owner deleted a comment from github-actions bot Jun 16, 2023
Repository owner deleted a comment from github-actions bot Jun 16, 2023
@s-vitaliy s-vitaliy changed the title Add code_quality pipeline Add mypy pipeline Jun 16, 2023
@s-vitaliy s-vitaliy marked this pull request as ready for review June 16, 2023 14:33
Copy link
Collaborator

@george-zubrienko george-zubrienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lidatong fyi, we'll be fixing all mypy errors in the following commits and then this check should be made required :)

@s-vitaliy s-vitaliy merged commit 14ae946 into master Jun 16, 2023
@s-vitaliy s-vitaliy deleted the ci/add_mypy branch June 16, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants