Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type order relevance for union wrapping 2 types #419

Merged
merged 6 commits into from
Jun 13, 2023

Conversation

george-zubrienko
Copy link
Collaborator

@george-zubrienko george-zubrienko commented Jun 10, 2023

Fixes #407

Scope

  • Fixed type order being relevant for resolution of actual type in union wrapping two types: None | str would be resolved to NoneType, while str | None would be resolved to str. Same was the case for Union, but not for Optional since that is an alias to <my type> | None
  • Added units to check type order doesn't matter anymore for union wrapping two types

@george-zubrienko george-zubrienko merged commit 2ca1d01 into master Jun 13, 2023
5 checks passed
bruxisma pushed a commit to ixm-one/pytest-cmake-presets that referenced this pull request Jul 20, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [dataclasses-json](https://togithub.com/lidatong/dataclasses-json) |
`0.5.8` -> `0.5.12` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/dataclasses-json/0.5.12?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/dataclasses-json/0.5.12?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/dataclasses-json/0.5.8/0.5.12?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/dataclasses-json/0.5.8/0.5.12?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>lidatong/dataclasses-json (dataclasses-json)</summary>

###
[`v0.5.12`](https://togithub.com/lidatong/dataclasses-json/releases/tag/v0.5.12)

[Compare
Source](https://togithub.com/lidatong/dataclasses-json/compare/v0.5.9...v0.5.12)

##### What's Changed

- Fix multiline scripts in CI by
[@&#8203;george-zubrienko](https://togithub.com/george-zubrienko) in
[lidatong/dataclasses-json#439

**Full Changelog**:
lidatong/dataclasses-json@v0.5.11...v0.5.12

###
[`v0.5.9`](https://togithub.com/lidatong/dataclasses-json/releases/tag/v0.5.9)

[Compare
Source](https://togithub.com/lidatong/dataclasses-json/compare/v0.5.8...v0.5.9)

#### What's Changed

- feat: add formalized issue template by
[@&#8203;s-vitaliy](https://togithub.com/s-vitaliy) in
[lidatong/dataclasses-json#417
- Fixing bug in decoder eval for optional fields by
[@&#8203;rpmcginty](https://togithub.com/rpmcginty) in
[lidatong/dataclasses-json#354
- Fix type order relevance for union wrapping 2 types by
[@&#8203;george-zubrienko](https://togithub.com/george-zubrienko) in
[lidatong/dataclasses-json#419
- Fix autocomplete when using annotation by
[@&#8203;george-zubrienko](https://togithub.com/george-zubrienko) in
[lidatong/dataclasses-json#411
- Add support for enhanced builtin instantiation by
[@&#8203;rpmcginty](https://togithub.com/rpmcginty) in
[lidatong/dataclasses-json#375
- Restore `schema()` type safety by fixing generic type alias misuse by
[@&#8203;andersk](https://togithub.com/andersk) in
[lidatong/dataclasses-json#371

#### New Contributors

- [@&#8203;s-vitaliy](https://togithub.com/s-vitaliy) made their first
contribution in
[lidatong/dataclasses-json#417
- [@&#8203;george-zubrienko](https://togithub.com/george-zubrienko) made
their first contribution in
[lidatong/dataclasses-json#419
- [@&#8203;andersk](https://togithub.com/andersk) made their first
contribution in
[lidatong/dataclasses-json#371

**Full Changelog**:
lidatong/dataclasses-json@v0.5.8...v0.5.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM2LjguMTEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarning occurs when using None | str as type in dataclass and using scheam.load().
2 participants