Skip to content

Commit

Permalink
fix: comment from review (#528)
Browse files Browse the repository at this point in the history
  • Loading branch information
PJCampi authored May 10, 2024
1 parent de0d230 commit 669ee33
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dataclasses_json/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,10 @@ def _decode_dataclass(cls, kvs, infer_missing):
def _decode_type(type_, value, infer_missing):
if _has_decoder_in_global_config(type_):
return _get_decoder_in_global_config(type_)(value)
if is_dataclass(type_) or is_dataclass(type_):
return _decode_dataclass(type_, value, infer_missing)
if _is_supported_generic(type_):
return _decode_generic(type_, value, infer_missing)
if is_dataclass(type_) or is_dataclass(value):
return _decode_dataclass(type_, value, infer_missing)
return _support_extended_types(type_, value)


Expand Down

6 comments on commit 669ee33

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
dataclasses_json
   cfg.py51492%80, 84–86
   core.py2721993%40–43, 53, 66, 68, 83, 85, 171, 199, 237, 381–388, 392, 398
   mm.py2053085%33–36, 42–45, 53–56, 62–65, 88, 170–171, 176, 180, 184, 189, 193, 197, 205, 211, 216, 225, 230, 235, 244, 253–260
   stringcase.py25388%59, 76, 97
   undefined.py146299%25, 39
   utils.py1343673%13–26, 46–51, 62–66, 76, 101–102, 110–111, 126–134, 164, 187, 212
tests
   entities.py239399%22, 234, 240
   test_annotations.py814248%50–67, 78–102, 106–122
   test_api.py142497%88, 99, 139–140
   test_str_subclass.py22195%9
   test_union.py1591591%99–106, 120–127, 274–278
TOTAL277615994% 

Tests Skipped Failures Errors Time
319 3 💤 0 ❌ 0 🔥 2.715s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
dataclasses_json
   cfg.py51492%80, 84–86
   core.py2721993%40–43, 53, 66, 68, 83, 85, 171, 199, 237, 381–388, 392, 398
   mm.py2053085%33–36, 42–45, 53–56, 62–65, 88, 170–171, 176, 180, 184, 189, 193, 197, 205, 211, 216, 225, 230, 235, 244, 253–260
   stringcase.py25388%59, 76, 97
   undefined.py146299%25, 39
   utils.py1343673%13–26, 46–51, 62–66, 76, 101–102, 110–111, 126–134, 164, 187, 212
tests
   entities.py239399%22, 234, 240
   test_annotations.py814248%50–67, 78–102, 106–122
   test_api.py142497%88, 99, 139–140
   test_str_subclass.py22195%9
   test_union.py1591591%99–106, 120–127, 274–278
TOTAL277615994% 

Tests Skipped Failures Errors Time
319 3 💤 0 ❌ 0 🔥 2.742s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
dataclasses_json
   cfg.py51492%80, 84–86
   core.py2711893%40–43, 53, 66, 68, 83, 85, 171, 237, 381–388, 392, 398
   mm.py2042986%33–36, 42–45, 53–56, 62–65, 88, 170–171, 176, 180, 184, 189, 193, 197, 205, 211, 216, 225, 230, 235, 253–260
   stringcase.py25388%59, 76, 97
   undefined.py146299%25, 39
   utils.py1342978%13–26, 46–51, 62–66, 76, 101–102, 110–111, 164, 187, 212
tests
   entities.py239399%20, 234, 240
   test_annotations.py814248%50–67, 78–102, 106–122
   test_api.py142299%139–140
   test_str_subclass.py22195%9
   test_union.py159597%274–278
TOTAL277413895% 

Tests Skipped Failures Errors Time
319 1 💤 0 ❌ 0 🔥 2.983s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
dataclasses_json
   cfg.py51492%80, 84–86
   core.py2711893%40–43, 53, 66, 68, 83, 85, 171, 237, 381–388, 392, 398
   mm.py2042986%33–36, 42–45, 53–56, 62–65, 88, 170–171, 176, 180, 184, 189, 193, 197, 205, 211, 216, 225, 230, 235, 253–260
   stringcase.py25388%59, 76, 97
   undefined.py146299%25, 39
   utils.py1342978%13–26, 46–51, 62–66, 76, 101–102, 110–111, 164, 187, 212
tests
   entities.py239399%22, 234, 240
   test_annotations.py814248%50–67, 78–102, 106–122
   test_api.py142199%139
   test_str_subclass.py22195%9
   test_union.py159597%274–278
TOTAL277413795% 

Tests Skipped Failures Errors Time
319 1 💤 0 ❌ 0 🔥 2.948s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
dataclasses_json
   cfg.py51492%80, 84–86
   core.py2721893%40–43, 53, 66, 68, 83, 85, 171, 237, 381–388, 392, 398
   mm.py2042986%33–36, 42–45, 53–56, 62–65, 88, 170–171, 176, 180, 184, 189, 193, 197, 205, 211, 216, 225, 230, 235, 253–260
   stringcase.py25388%59, 76, 97
   undefined.py144299%25, 39
   utils.py1342978%13–26, 46–51, 62–66, 76, 101–102, 110–111, 164, 187, 212
tests
   entities.py218399%20, 234, 240
   test_annotations.py804248%50–67, 78–102, 106–122
   test_api.py140299%139–140
   test_str_subclass.py22195%9
   test_union.py134596%274–278
TOTAL264313895% 

Tests Skipped Failures Errors Time
319 1 💤 0 ❌ 0 🔥 2.753s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
dataclasses_json
   cfg.py51492%80, 84–86
   core.py2721993%40–43, 53, 66, 68, 83, 85, 171, 199, 237, 381–388, 392, 398
   mm.py2053085%33–36, 42–45, 53–56, 62–65, 88, 170–171, 176, 180, 184, 189, 193, 197, 205, 211, 216, 225, 230, 235, 244, 253–260
   stringcase.py25388%59, 76, 97
   undefined.py146299%25, 39
   utils.py1343673%13–26, 46–51, 62–66, 76, 101–102, 110–111, 126–134, 164, 187, 212
tests
   entities.py239399%22, 234, 240
   test_annotations.py814248%50–67, 78–102, 106–122
   test_api.py142497%88, 99, 139–140
   test_str_subclass.py22195%9
   test_union.py1591591%99–106, 120–127, 274–278
TOTAL277615994% 

Tests Skipped Failures Errors Time
319 3 💤 0 ❌ 0 🔥 4.640s ⏱️

Please sign in to comment.