-
Notifications
You must be signed in to change notification settings - Fork 49
Implementing URI::smb for Samba/CIFS #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @buralien!
@buralien please see the failing tests. |
The overridden The methods also seem to be unescaping twice, since the parent |
I apologize for the lack of focus when writing the code. I have fixed the comments and the failing tests. Thanks for helping me think more :) |
Is there anything I can do to help fix these failing builds? It doesn't seem like anything from my code, but I could be wrong. |
Thanks for the offer. 🙏🏻 You could try disabling |
Looks like we can just exclude 5.16 on Windows from the build matrix. |
@haarg does this look ok now? |
This simple addition will allow working with smb scheme URIs.