Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody missed it before; why would they now?
Ref #1344.
Was going through the code and found some unused code.
https://github.com/libssh2/libssh2/blob/master/src/channel.c#L2009-L2017
if
channel->extData2_state == libssh2_NB_state_idle
when the function starts, then the first if changes it tolibssh2_NB_state_created
and then for the next if the state won't be idle anymore, and the second if won't run. If it's not idle, then nothing happens, and the state is reset to idle.Really this is the only function that uses
extData2_state
So the function becomes just
and
extData2_state
can be removed from the channel structure.Or - maybe if there is really a flush still desired, maybe the second if should use
channel->extData2_state == libssh2_NB_state_created
instead ofchannel->extData2_state == libssh2_NB_state_idle
.