Windows: Prevent assertion pop-up up when using Debug compiled libressl. #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the signertest, or the test project in libressl#266 an assertion window pops up. This was fixed in afcd4be for a release compiled library. To prevent the issue in debug mode, it looks like it is necessary to also disable the assertion window popup. With this all tests pass when compiling and running them with a Debug, Release or RelWithDebInfo CMake build on windows (for me).
|
It is this one that pops up:
when for example running the signertest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to run the test suite in Debug mode on windows and had an assertion window pop.
It happens when running the signertest, or the test project in #266. This was fixed in afcd4be for a release compiled library. To prevent the issue in debug mode, it looks like it is necessary to also disable the assertion window popup.
With this all tests pass when compiling and running them with a Debug, Release or RelWithDebInfo CMake build on windows (for me).