-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: clean up Windows workflow #979
Conversation
I should have caught this earlier: for cmake builds you can run
./update.sh instead of ./autogen.sh and there should be no need
for autotools/automake/libtool.
|
Ah, okay. I've pushed a commit to make those changes. |
Ah, okay. I've pushed a commit to make those changes.
Is autoconf still needed?
|
I do not know. I will try removing it and see if it still builds. The previous commit seems to have reduced the total workflow duration from 14-27 minutes to 7 minutes. |
Not sure what you are signalling with assigning this to yourself.
Should I merge if green or is there more you want to do here?
|
Sorry for the confusion, in another project I often use the pull request assignees to show who is working on the pull request, and did so here out of habit. This should be good to merge now. |
Clean up existing
windows
GitHub Actions workflow.Changes:
windows_test.yml
towindows.yml
contents: read
actions/checkout
tov4
actions/upload-artifact
tov4
README.md
file