Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean up Windows workflow #979

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Conversation

joshuasing
Copy link
Member

Clean up existing windows GitHub Actions workflow.

Changes:

  • Move windows_test.yml to windows.yml
  • Restrict token permissions to contents: read
  • Pin actions/checkout to v4
  • Update actions/upload-artifact to v4
  • Overall tidy up
  • Use more common naming conventions
  • Add schedule to run weekly
  • Add Windows workflow badge to README.md file

@joshuasing joshuasing added the CI label Dec 19, 2023
@joshuasing joshuasing self-assigned this Dec 19, 2023
@botovq
Copy link
Contributor

botovq commented Dec 19, 2023 via email

@joshuasing
Copy link
Member Author

I should have caught this earlier: for cmake builds you can run ./update.sh instead of ./autogen.sh and there should be no need for autotools/automake/libtool.

Ah, okay. I've pushed a commit to make those changes.

@botovq
Copy link
Contributor

botovq commented Dec 19, 2023 via email

@joshuasing
Copy link
Member Author

Ah, okay. I've pushed a commit to make those changes.
Is autoconf still needed?

I do not know. I will try removing it and see if it still builds.

The previous commit seems to have reduced the total workflow duration from 14-27 minutes to 7 minutes.

@botovq
Copy link
Contributor

botovq commented Dec 19, 2023 via email

@joshuasing
Copy link
Member Author

Not sure what you are signalling with assigning this to yourself. Should I merge if green or is there more you want to do here?

Sorry for the confusion, in another project I often use the pull request assignees to show who is working on the pull request, and did so here out of habit. This should be good to merge now.

@botovq botovq merged commit a21a503 into libressl:master Dec 19, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants