Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: stop exporting compat functions #972

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

vszakats
Copy link
Contributor

@vszakats vszakats commented Dec 14, 2023

Attempt to avoid EXTRA_EXPORT and LIBTLS_EXTRA_EXPORT, by doing something
similar to what autotools builds do already.

Fixes #969


Locally I could only test a 3.8.2-based iteration and one that didn't tackle LIBTLS_EXTRA_EXPORT. CI should tell more.

@vszakats vszakats marked this pull request as draft December 14, 2023 03:40
@vszakats vszakats marked this pull request as ready for review December 14, 2023 05:20
Copy link
Contributor

@botovq botovq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Many thanks!

I have come up with a subset of this diff, but haven't gotten quite as far. All the changes make sense. I wonder if we can use a relatively recent API that will likely be needed everywhere such as recallocarray in place of empty.c.

crypto/CMakeLists.txt Show resolved Hide resolved
@botovq botovq changed the title [WIP] cmake: stop exporting compat functions cmake: stop exporting compat functions Dec 14, 2023
@botovq botovq merged commit f1cfcd5 into libressl:master Dec 14, 2023
35 checks passed
@vszakats vszakats deleted the cmake-keep-compat-unexported branch December 14, 2023 12:52
@vszakats
Copy link
Contributor Author

I wonder if we can use a relatively recent API that will likely be needed everywhere such as recallocarray in place of empty.c.

That would make sense. (Another option is making the compat lib names a variable, then leaving them empty and omitting these targets altogether when empty. Though this has more moving parts so I'd only do it if the compat functions are expected to disappear mid term.)

@busterb
Copy link
Contributor

busterb commented Feb 19, 2024

Note: skipping this PR for stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why do CMake builds still have EXTRA_EXPORTs?
3 participants