remove additional endbr64 patch, add tests for macos-11 #945
Conversation
|
On Thu, Nov 09, 2023 at 09:28:58PM -0800, Joshua Sing wrote:
@joshuasing approved this pull request.
I haven't yet had a chance to look at the details of this failure
because github helpfully hides them when not logged in, but what I'm
most concerned about is that I didn't get notified of the test failure.
|
|
It wasn't that there was a failure we didn't get notified; more that there was no failure at all. The issue seemed to only occur if you have an older compiler. All of my local machines and the Github images were new enough that they all worked without showing a problem. I'm not 100% sure that enabling the macos-11 image in this PR is enough, since it might have a newer compiler too compared to what someone using Apple's Xcode would have: https://github.com/actions/runner-images/blob/main/images/macos/macos-11-Readme.md . Testing that now. |
|
Yep, it's not enough; this line was intended to have failed, but didn't: https://github.com/libressl/portable/actions/runs/6822970903/job/18555981286#step:4:703 |
|
Examining some of the other build results, it appears that the architecture attribute is not doing anything either; the arm64 target is still building x86_64: https://github.com/libressl/portable/actions/runs/6822970903/job/18555980718#step:4:686 |
|
Yes, sorry, I accidentally replied to the wrong thread. This was about #944. |
busterb
force-pushed
the
macos-endbr64
branch
from
b34bd93 to
96e5e35
Compare
|
Apologies for the mess. |
Fixes #933 , revert one additional patch when targeting macos/windows