cmake: simplify if expressions, accept CPU values more consistently #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it accept values consistently. Before this patch mingw-w64, Apple and SunOS did not accept a CPU if it had a suffix or prefix (e.g. a triplet), while other targets did.
busterb
added a commit
that referenced
this pull request
Nov 8, 2023
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Nov 8, 2023
Made possible by this upstream patch: libressl/portable#938 libressl/portable@88510a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify
MATCHES/STREQUALsyntax.always check
CMAKE_SYSTEM_PROCESSORwithMATCHES.This makes it accept values consistently. Before this patch
mingw-w64, Apple and SunOS did not accept a CPU if it had
a suffix or prefix (e.g. a triplet), while other targets did.